docker monitor remote monitoring bugfix #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
Signed-off-by: Glenn Lim <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1499 +/- ##
=======================================
Coverage ? 55.89%
=======================================
Files ? 105
Lines ? 4507
Branches ? 688
=======================================
Hits ? 2519
Misses ? 1435
Partials ? 553
Flags with carried forward coverage won't be shown. Click here to find out more. |
davidkel
approved these changes
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue/User story
#1493
Steps to Reproduce
Existing issues
How do I measure the performance of remote docker container in hyperledger caliper?
Design of the fix
Removed .remote in line 75 of monitor-docker.js, was likely a typo that was just missed since filterName has no property named remote
Validation of the fix
Ran a remote monitoring with good results
report.zip